Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing gen-flow-files with flow-copy-source waiting for a replacement #1445

Merged
merged 4 commits into from
Jan 22, 2019

Conversation

chrisdugne
Copy link
Contributor

@chrisdugne chrisdugne commented Jan 22, 2019

Detailed purpose of the PR

replacing gen-flow-files with flow-copy-source waiting for facebook/flow#5871 (comment)

Result and observation

  • Breaking changes ?
    If checked, what have you broken ?

  • Extra lib ?
    If checked, Which extra lib did you add ? (name, purpose, link ...).

flow-copy-source

Testing Strategy

  • Already covered by tests
  • Manual testing
  • Unit testing

@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #1445 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1445     +/-   ##
========================================
  Coverage     100%    100%             
========================================
  Files          13      97     +84     
  Lines         328    1646   +1318     
========================================
+ Hits          328    1646   +1318
Impacted Files Coverage Δ
...oorpacademy-player-store/src/reducers/data/rank.js 100% <0%> (ø)
.../@coorpacademy-player-services/src/progressions.js 100% <0%> (ø)
...-progression-engine/src/compute-next-step/index.js 100% <0%> (ø)
...pacademy-progression-engine/src/reducers/slides.js 100% <0%> (ø)
...rpacademy-player-store/src/reducers/ui/comments.js 100% <0%> (ø)
...ges/@coorpacademy-progression-engine/src/errors.js 100% <0%> (ø)
...oorpacademy-player-store/src/utils/memoize-task.js 100% <0%> (ø)
...orpacademy-player-store/src/actions/ui/location.js 100% <0%> (ø)
...pacademy-player-store/src/actions/ui/extra-life.js 100% <0%> (ø)
...cademy-player-store/src/actions/ui/progressions.js 100% <0%> (ø)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc3f2a...36b6e2b. Read the comment docs.

@coorpacademybot coorpacademybot requested a review from a team January 22, 2019 12:08
@chrisdugne chrisdugne changed the title Cleanup store replacing gen-flow-files with flow-copy-source waiting for a replacement Jan 22, 2019
@coorpacademybot coorpacademybot requested a review from a team January 22, 2019 13:05
@chrisdugne chrisdugne merged commit 1ea7442 into master Jan 22, 2019
@chrisdugne chrisdugne deleted the cleanup-store branch January 22, 2019 13:37
@VincentCATILLON
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants