Refreshed and improved to support bootstraping of major upgrade PR 🚀 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic addressing of #52
used latest version supporting require
default is still the new introduce --force-with-lease mode
async/await refactors and use instead p-* family from sindresorhus, in a version supporting requires
AdrieanKhisbe
added
New Feature 🚀
Upgrades 📤
dependencies
adamska27
reviewed
Sep 19, 2024
test/integration/package.json
Outdated
| @@ -21,7 +21,8 @@ | |||
| "author": "Mr X @Coorp", | |||
| "license": "MIT", | |||
| "engines": { | |||
| "node": "^18.0.0" | |||
| "node": "^12.22.12", | |||
There was a problem hiding this comment.
mmmm, good catch. looks like an oversight!
There was a problem hiding this comment.
@adamska27 the nvmrc wasn't updated in the node 18. So running code locally restored the test version.
I just updated the all the version in the test/integration (in bbfa790)
silouone
reviewed
Sep 19, 2024
| @@ -15,7 +15,8 @@ | |||
| ], | |||
| "rules": { | |||
| "no-continue": "off", | |||
| "fp/no-loops": "off" | |||
| "fp/no-loops": "off", | |||
| "no-nested-ternary": "off", | |||
silouone
reviewed
Sep 19, 2024
| @@ -74,9 +81,23 @@ const resolveConfig = async (config, configPath, argv) => { | |||
| base.node.travis = defaultWithPath(base.node.travis, '.travis.yml'); | |||
| base.node.package = defaultWithPath(base.node.package, 'package.json'); | |||
| } | |||
| base.argv = argv; | |||
| base.forceFlag = argv.force ? '--force' : '--force-with-lease'; | |||
There was a problem hiding this comment.
what are the scenario where you would use --force without lease 😂 ❓
There was a problem hiding this comment.
I had to few time to use it doing testing.
StefanoA1
reviewed
Sep 23, 2024
StefanoA1
approved these changes
Sep 23, 2024
esa-coorp
approved these changes
Sep 25, 2024
adamska27
approved these changes
Sep 25, 2024
|
🚀 |
AdrieanKhisbe
added a commit
that referenced
this pull request
Oct 14, 2024
…more resilient 🪭 (#147) Merge pull request #147 from CoorpAcademy/refreshed-and-improved--more New huge set of enhancements to the project, following #143 with main goal to make this usable on project with no prior config, and handle command lib with adherence to node version (lerna and serverless). Also program was improved not to require a clean state before running. Less config is needed, the program can be run out of the box on any node repository ------ Exemple of command ran: (that boostrapped that PR: CoorpAcademy/coorpacademy-lambda#1590) ```bash update-node upgrade --target 20 -dcam "Update-node major bump 📤" -R @CoorpAcademy/development-mooc -F api-media -s media ``` flags: - `d` for default config 🆕 7eb2685 - `c` for clean, cleanup before running 🆕 c6e0220 - `a` for autofigure what to do - `target`(t) to search to bump for a specific node version (from #143) - `F` to target a folder (was ran from `coorpacademy-lambda` root (from #143) - `s` to `scope` in monorepo (scoped added in title and branch name) 🆕 a1faa74 - `R` to set reviewer (from #143) ------ serverless+lerna support: Serverless runtime will be updated, and every package in a lerna mono repo will be updated ⚡🐲 8fffb7f + 22dcf55 Some adjustement where also made for the program to be more flexible with the baseBranch, supporting non `master` branches
AdrieanKhisbe
added a commit
that referenced
this pull request
Oct 21, 2024
Merge pull request #148 from CoorpAcademy/refreshed-and-improved--more-more #143 and #147 follow up, with few enhancement and glitch fixes - Sync the package-lock (by default, and with node nvm version loaded) 🔄 - Add hook `-b`/`--pre-commit-bump-command` to inject commands (like updating a specific package with `ncu`) 🪝 - Restore force push for the autobump ⛑️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge set of enhancements to the project, with main goals to refresh dependencies and to support the add hoc draft of major bump pull requests
Refreshing 🌬️
New features 🚀