Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typos checks and fix typos it found #580

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

philderbeast
Copy link

I'd recently fixed many typos in haskell/cabal using the typos tool, see haskell/cabal#10613 and haskell/cabal#10603. I tried the tool here and found many typos.

There's already pull request #558 that fixes issue #560.

I've read the contributing notes and annotated commits with #560 but can change this issue reference to another if you want to raise one or more separate issues.

As for the GitHub action, this is using the makefile not the typos action that I tried, the same as we're using with haskell/cabal. I could get their action to work for ./**/*.md files but not ./**/*.hs files even though both work locally.

I haven't added CHANGELOG entries as I'm not yet sure if you'd like this pull request to remain whole or split up. As it is now, it touches copilot-c99, copilot-interpreter, copilot-language, copilot-theorem and copilot/examples (for which there isn't a CHANGELOG).

$ tree -P 'CHANGELOG' --prune
.
├── copilot
│   └── CHANGELOG
├── copilot-c99
│   └── CHANGELOG
├── copilot-core
│   └── CHANGELOG
├── copilot-interpreter
│   └── CHANGELOG
├── copilot-language
│   └── CHANGELOG
├── copilot-libraries
│   └── CHANGELOG
├── copilot-prettyprinter
│   └── CHANGELOG
└── copilot-theorem
    └── CHANGELOG

…#560

- Only ignore dist- folder
- Try but reject use typos github action
- Write changes for hs-fix-typos
- Add alse (parse "f" then "alse") to expected words
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant