Fix for bug6940. Related pages" links only work intermittently #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 25, 2014 16:14
are updated after new pages are added. https://bugs.corefiling.com/show_bug.cgi?id=6940
is no delete action in the case where the page content is empty, so we can simplify this get method. https://bugs.corefiling.com/show_bug.cgi?id=6940
attributes have changed. We store two maps on the search index: 1. page uid -> rendered content hash 2. page uid -> sorted list of page attrs hash We check the computed hashes of the page against the stored ones before updating the index. https://bugs.corefiling.com/show_bug.cgi?id=6940
the SearchEngine index contains information on the latest rendered copy of a page. This method is now independent from the index method, you only need to check isIndexUpToDate if you're considering indexing a page upon page GET, not page POST or otherwise. https://bugs.corefiling.com/show_bug.cgi?id=6940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling SearchIndexPopulatingPageStore.get to fetch a page, update the search index if the latest rendered contents of the page (possibly modified by changed output of search macros), or attributes have changed.
https://bugs.corefiling.com/show_bug.cgi?id=6940