Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cell type enum, date/sharedStrings helpers #102

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

New stringValue and dateValue helpers on the Cell type are added, which allow getting corresponding string (including shared strings) and date values easier.

Resolves #71
Resolves #89

@MaxDesiatov MaxDesiatov added enhancement New feature or request documentation Documentation improvements labels Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #102 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   98.12%   98.23%   +0.11%     
==========================================
  Files           8        8              
  Lines         267      284      +17     
==========================================
+ Hits          262      279      +17     
  Misses          5        5              
Impacted Files Coverage Δ
Sources/CoreXLSX/Worksheet/CellQueries.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdaf991...23d8f1a. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit ea01f05 into master Apr 6, 2020
@MaxDesiatov MaxDesiatov deleted the string-date-helpers branch April 6, 2020 21:02
@MaxDesiatov MaxDesiatov added the breaking change Change that breaks API compatibility label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Change that breaks API compatibility documentation Documentation improvements enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading Date values from cell Getting the value of a cell with number format?
2 participants