Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font(in:) and format(in:) functions #135

Merged
merged 4 commits into from
Nov 28, 2020
Merged

Add font(in:) and format(in:) functions #135

merged 4 commits into from
Nov 28, 2020

Conversation

MaxDesiatov
Copy link
Collaborator

Resolve #134

@MaxDesiatov MaxDesiatov added the enhancement New feature or request label Nov 28, 2020
@MaxDesiatov MaxDesiatov mentioned this pull request Nov 28, 2020
@MaxDesiatov
Copy link
Collaborator Author

MaxDesiatov commented Nov 28, 2020

@CMiller3 would you mind having a quick look at the diff? Please let me know if this API makes sense. 🙂

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #135 (158076b) into main (e390c57) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   97.00%   97.05%   +0.05%     
==========================================
  Files           9        9              
  Lines         300      306       +6     
==========================================
+ Hits          291      297       +6     
  Misses          9        9              
Impacted Files Coverage Δ
Sources/CoreXLSX/Worksheet/CellQueries.swift 91.17% <100.00%> (+1.89%) ⬆️
Sources/CoreXLSX/XLSXFile.swift 96.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e390c57...158076b. Read the comment docs.

@CMiller3
Copy link

I really have no business giving opinions on this -- but yeah man, definitely helps clarify what to expect from the API! Thanks for the swift fixes ;)

@MaxDesiatov MaxDesiatov merged commit 72ca7b0 into main Nov 28, 2020
@MaxDesiatov MaxDesiatov deleted the cell-styles branch November 28, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odd cell.s value
2 participants