Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Worksheet and Pane values to optional #31

Merged
merged 3 commits into from
Jan 11, 2019
Merged

Conversation

hodovani
Copy link
Contributor

@hodovani hodovani commented Jan 11, 2019

Resolves partially #28

MaxDesiatov
MaxDesiatov previously approved these changes Jan 11, 2019
@codecov
Copy link

codecov bot commented Jan 11, 2019

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files           5        5           
  Lines         220      220           
=======================================
  Hits          216      216           
  Misses          4        4
Impacted Files Coverage Δ
Sources/CoreXLSX/Worksheet/Worksheet.swift 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e9b4f...c5acf8f. Read the comment docs.

@hodovani hodovani merged commit af9d16d into master Jan 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/coding-keys branch January 11, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants