Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OutputFormatting = .sortedKeys #52

Closed
VadimPavlov opened this issue Jan 2, 2019 · 2 comments
Closed

OutputFormatting = .sortedKeys #52

VadimPavlov opened this issue Jan 2, 2019 · 2 comments

Comments

@VadimPavlov
Copy link

VadimPavlov commented Jan 2, 2019 •
edited
Loading

I believe there is no reason for @available in (legacy code from JSONEncoder?)
@available(macOS 10.13, iOS 11.0, watchOS 4.0, tvOS 11.0, *)
public static let sortedKeys = OutputFormatting(rawValue: 1 << 1)
@regexident
Copy link
Contributor

regexident commented Jan 2, 2019 •
edited
Loading

You're absolutely right, @VadimPavlov!

It's a relict of the initial forking of stdlib's JSONCoding code.

I created a PR for it: #53

@MaxDesiatov
Copy link
Collaborator

MaxDesiatov commented Jan 2, 2019 •
edited
Loading

Thanks for reporting this @VadimPavlov, #53 has been merged to master now and I believe this issue can be closed. Please feel free to reopen it with more details if needed.

bwetherfield pushed a commit to bwetherfield/XMLCoder that referenced this issue Oct 1, 2019
@jsbean
Merge pull request CoreOffice#52 from jsbean/tidy-singlekeyed
f2cac43 
Refactor XMLKeyedDecodingContainer.decodeConcrete elements massaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MaxDesiatov @regexident @VadimPavlov