Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor .sortedKeys (redux) #14

Merged
merged 8 commits into from
Dec 4, 2018
Merged

Conversation

qmoya
Copy link
Contributor

@qmoya qmoya commented Dec 3, 2018

This PR supersedes #11, which had some unwanted commits added to it. It addresses the formatting issues mentioned by @MaxDesiatov.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #14 into master will increase coverage by 1.41%.
The diff coverage is 23.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   24.58%   25.99%   +1.41%     
==========================================
  Files          12       12              
  Lines        1554     1585      +31     
==========================================
+ Hits          382      412      +30     
- Misses       1172     1173       +1
Impacted Files Coverage Δ
Sources/XMLCoder/ISO8601DateFormatter.swift 0% <ø> (ø) ⬆️
...rces/XMLCoder/Decoder/DecodingErrorExtension.swift 0% <ø> (ø) ⬆️
...urces/XMLCoder/Encoder/XMLReferencingEncoder.swift 0% <0%> (ø) ⬆️
...rces/XMLCoder/Encoder/EncodingErrorExtension.swift 0% <0%> (ø) ⬆️
...s/XMLCoder/Decoder/XMLKeyedDecodingContainer.swift 11.88% <10.92%> (ø) ⬆️
Sources/XMLCoder/Decoder/XMLDecoder.swift 22.61% <19.04%> (ø) ⬆️
Sources/XMLCoder/Encoder/XMLEncoder.swift 22.93% <20.85%> (+0.04%) ⬆️
Sources/XMLCoder/XMLKey.swift 25% <50%> (ø) ⬆️
...XMLCoder/Decoder/XMLUnkeyedDecodingContainer.swift 7.56% <6.74%> (ø) ⬆️
Sources/XMLCoder/Encoder/XMLEncodingStorage.swift 87.5% <83.33%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65d765...a876df8. Read the comment docs.

@qmoya
Copy link
Contributor Author

qmoya commented Dec 3, 2018

Hi @MaxDesiatov: codecov/patch failed because the PR doesn't have tests for all the files that have been reformatted by SwiftFormat. 😄 But I believe it's ready to merge.

Once you do that, I'll suggest another PR that adds character data support for encoding and decoding.

Thanks!

@MaxDesiatov
Copy link
Collaborator

LGTM, thanks!

@MaxDesiatov MaxDesiatov merged commit ffdeed2 into CoreOffice:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants