Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixed CDATA usage #261

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Fix mixed CDATA usage #261

merged 1 commit into from
Apr 12, 2023

Conversation

johankool
Copy link
Contributor

Fixes #260

@Joannis
Copy link
Member

Joannis commented Apr 7, 2023

Thanks for your contribution! I'll let the tests run, and run it through myself. But it looks good for sure.

@johankool
Copy link
Contributor Author

Not sure what went wrong with the tests. Can they be re-run?

@Joannis
Copy link
Member

Joannis commented Apr 11, 2023

Done

@johankool
Copy link
Contributor Author

Not sure what to do about this. I don't have Xcode 13.1 on macOS 11.0 available to me, so can't easily reproduce. Not sure why anyone would still use that either.

@Joannis
Copy link
Member

Joannis commented Apr 12, 2023

I agree with you @johankool , it's an old platform. And even the Xcode build is old for the specific platform. If you want, you can replace the target with a Ventura / Xcode 14 one to get the tests running. I'll make sure we'll also add Linux/5.7 and Linux/5.8 after that.

@Joannis
Copy link
Member

Joannis commented Apr 12, 2023

Actually, the latest tests (Xcode 14, macOS 12) never ran to begin with. So I do think there's something at play.

@Joannis Joannis merged commit 666227d into CoreOffice:main Apr 12, 2023
@Joannis
Copy link
Member

Joannis commented Apr 12, 2023

I feel like this is a github runner issue, so I've merged it.

@johankool johankool mentioned this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDATA usage in array of tags gives empty string instead of value
2 participants