Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back private_over_fileprivate for SwiftLint #67

Merged
merged 7 commits into from
Jan 20, 2019
Merged

Add back private_over_fileprivate for SwiftLint #67

merged 7 commits into from
Jan 20, 2019

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented Jan 19, 2019 •
edited
Loading

General cleanups before 0.3 release and an attempt to make Jazzy run on CI (failed so far)

@MaxDesiatov MaxDesiatov self-assigned this Jan 19, 2019
@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files          31       31           
  Lines        1489     1489           
=======================================
  Hits         1126     1126           
  Misses        363      363

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401de6a...9eada7c. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 19, 2019 •
edited
Loading

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   75.62%   75.62%           
=======================================
  Files          31       31           
  Lines        1489     1489           
=======================================
  Hits         1126     1126           
  Misses        363      363

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401de6a...ec6086a. Read the comment docs.

@MaxDesiatov MaxDesiatov changed the title Upload docs generated by Jazzy in CI builds Add back private_over_fileprivate for SwiftLint Jan 19, 2019
@MaxDesiatov MaxDesiatov requested a review from hodovani January 19, 2019 16:27
hodovani
hodovani approved these changes Jan 20, 2019
View reviewed changes
Copy link
Contributor

@hodovani hodovani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice commits title @MaxDesiatov 👍🏻

@MaxDesiatov
Copy link
Collaborator Author

Thanks @hodovani 😄

@MaxDesiatov MaxDesiatov merged commit b8b1ed7 into master Jan 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the release-cleanup branch January 20, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodovani hodovani hodovani approved these changes

Assignees

@MaxDesiatov MaxDesiatov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @hodovani