Cleanup pr 331 #366
Merged
Cleanup pr 331 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- produced weird autio clip thought
print to console when using cpu
nothing other than wav works, even though comment says it does...
just in case people use quotes
(functions untoched, just variables)
-exclude .gz
-- need to run on native linux
-- issue with spaces in path for input file Testing: -- remove all packages from requirements that aren't neccesary for demo_cli.py. Slowly add them back in.
- fpath fix for load from file - updated calls for librosa 0.8.0 (changed wav write to file) - partial update for tensorflow 2.0 api
compatible with tensorflow v2 api -- big issue -- The RNN model makes heavy usage of tf.contrib, which was dropped in v2. All the methods were changed, variables, etc. Will require extensive rework. Possible rewrite.
-- grammar -- easier to understand -- better instructions for usage
-- spelling corrections -- formatting
-- formatting
-- tested from scratch on google compute
added 10 commits
June 22, 2020 00:03
ghost
mentioned this pull request
ghost
merged commit 
|
Real-Time-Voice-Cloning/encoder/train.py Line 14 in 1e16877 The torch.cpu is giving me "AttributeError: module 'torch' has no attribute 'cpu'" |
This was referenced Jun 29, 2020
Closed
Closed
ghost
mentioned this pull request
ghost
mentioned this pull request
Closed
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very carefully cleaned up version of #331. It implements suggestions provided by @CorentinJ and removes unnecessary changes for ease of review.
Thanks to @pusalieth for the original implementation of these changes for CPU support.