Export and replay generated wav #402
Conversation
|
@matheusfillipe I tested the update and it works very nicely. The replay and history features are a very useful addition! |
|
I think the extension issue is fixed now, on my system the default is wav for some reason :P |
toolbox/__init__.py
Outdated
| #TODO better naming for the combobox items? | ||
| self.ui.waves_list_model.setStringList(["%d" % (i+1) for i in range(n_waves)]) | ||
| self.ui.waves_cb.setCurrentIndex(n_waves-1) | ||
| cb_items = ["%d" % (self.waves_count - i) for i in range(0, min(self.waves_count, MAX_WAVES))] |
There was a problem hiding this comment.
What I intended to suggest is to maintain a list called self.waves_namelist and append the count to the list (as a string) every time a wave is made.
This will make it easier to implement the TODO.
There was a problem hiding this comment.
I am already doing on line 250:
self.waves_namelist = ["%d" % (self.waves_count - i) for i in range(0, min(self.waves_count, MAX_WAVES))]
I am recreating the list every time, because this is exactly what goes on the combobox, and I wouldn't be able to just keep appending to it unless if poping 0 like in line 247 with self.waves_list and then reverting this one but I don't actually see how is that going to help on the todo. Is that what you mean anyway?
What I meant by that TODO is that maybe there is a better way to name those or let the user name them.
|
Thanks for addressing my feedback @matheusfillipe ! There is one more here: #402 (comment) |
|
I have pushed some suggested changes to the source branch (matheusfillipe:save_and_replay_wav). |
Update and bugfix for toolbox GUI
ghost
requested a review
from
|
@CorentinJ Requesting your feedback on these changes. |
|
Clear to perform squash and merge @matheusfillipe . Thank you for this very nice toolbox enhancement. |
|
Hi @matheusfillipe , please go ahead and perform the squash and merge. |
I don't have write access @blue-fish . |
|
My apologies @matheusfillipe , I got "collaborator" and "contributor" mixed up and thought that you would have write access as a contributor. I'll merge it in now. |
ghost
mentioned this pull request
ghost
mentioned this pull request
So this is my attempt of adding replay and export functions. I first thought on only keeping the last played wav, but then I thought would be nice to let the user choose among the last generated ones for like, comparing and choosing the best.
I added a new row on the right side for the 3 new widgets. Turned out to be the best placement and I hope this is fine until the interface cleanup. The interface looks like this now: