Print helpful error message if models not found #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
CorentinJ
reviewed
Jul 10, 2020
demo_cli.py
Outdated
Comment on lines
56
to
61
| ## Print helpful error message if models are not present | ||
| if not args.enc_model_fpath.is_file(): | ||
| if not args.syn_model_dir.is_dir(): | ||
| if not args.voc_model_fpath.is_file(): | ||
| print("Error: Model files not found. If needed, download them here: https://github.com/CorentinJ/Real-Time-Voice-Cloning/wiki/Pretrained-models") | ||
| quit(-1) |
There was a problem hiding this comment.
- Extract a function so you can reuse instead of duplicating the code
- Use
ands instead of chainingifs - Break the line above 100 chars
There was a problem hiding this comment.
Thank you for the suggestions @CorentinJ . The latest commit should resolve these issues. Let me know if you think of any other improvements.
CorentinJ
approved these changes
Jul 10, 2020
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of people don't know what to do with the "No encoder models found in encoder/saved_models" error message, leading to issues like #387, #393 and #412.
We just updated README.md to emphasize that downloading the pretrained models is part of the setup process, in #414 . However, I would also like to print a helpful error message when no models are found. This will allow the user to fix their own problem.