Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset FT + DEX migration #1040

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Asset FT + DEX migration #1040

merged 3 commits into from
Dec 4, 2024

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Dec 3, 2024

Description

Asset FT + DEX migration

  • Add asset FT migration to add IBC features for FT with extension feature enabled + upgrade tests
  • Add DEX upgrade tests to test the order placement/execution for previously issued FTs.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

* Add asset FT migration to add IBC features for FT with extension feature enabled + upgrade tests
* Add DEX upgrade tests to test the order placement/execution for previously issued FTs.
@dzmitryhil dzmitryhil requested a review from a team as a code owner December 3, 2024 09:00
@dzmitryhil dzmitryhil requested review from masihyeganeh, miladz68 and ysv and removed request for a team December 3, 2024 09:00
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.44%. Comparing base (28bc015) to head (8ee42ee).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
x/asset/ft/keeper/migrations.go 33.33% 2 Missing ⚠️
x/asset/ft/module.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
+ Coverage   60.47%   62.44%   +1.96%     
==========================================
  Files         160      160              
  Lines       18585    18589       +4     
==========================================
+ Hits        11240    11608     +368     
+ Misses       6242     5863     -379     
- Partials     1103     1118      +15     
Flag Coverage Δ
coreum 57.09% <70.00%> (+<0.01%) ⬆️
coreum-integration-tests-modules 52.54% <20.00%> (+6.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@dzmitryhil dzmitryhil merged commit 9160b13 into master Dec 4, 2024
11 checks passed
@dzmitryhil dzmitryhil deleted the dzmitryhil/dex-migration branch December 4, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants