Added test to check multisig and authz work together

[miladz68]

This change is 

[ysv]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dzmitryhil, @miladz68, @silverspase, and @wojtek-coreum)

---

integration-tests/modules/auth_test.go line 227 at r1 (raw file):

// TestAuthMultisigWithAuthz tests the cosmos-sdk multisig accounts works with authz.
func TestAuthMultisigWithAuthz(t *testing.T) {

The logic we wanted to test is different:

granter should be multisig account
and grantee should be usual account

---

integration-tests/modules/auth_test.go line 227 at r1 (raw file):

// TestAuthMultisigWithAuthz tests the cosmos-sdk multisig accounts works with authz.
func TestAuthMultisigWithAuthz(t *testing.T) {

minor:
IMO more logical place for this test is authz_test

---

integration-tests/modules/auth_test.go line 234 at r1 (raw file):

	requireT := require.New(t)

	signer1KeyInfo, err := chain.ClientContext.Keyring().KeyByAddress(chain.GenAccount())

IMO it makes sense to move multisig acc creation logic to a separate func since we reuse it in multiple places now

smth like:

func GenMultisig(sigNumber, threshold uint) # returns multisig account & list of signers

[ysv]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dzmitryhil, @miladz68, @silverspase, and @wojtek-coreum)

[dzmitryhil]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)

---

integration-tests/modules/auth_test.go line 234 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

IMO it makes sense to move multisig acc creation logic to a separate func since we reuse it in multiple places now

smth like:

func GenMultisig(sigNumber, threshold uint) # returns multisig account & list of signers

Agree, because the code of the test is simpler than test preparation.

[dzmitryhil]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)

[miladz68]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)

---

integration-tests/modules/auth_test.go line 227 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

The logic we wanted to test is different:

granter should be multisig account
and grantee should be usual account

Done both ways.

---

integration-tests/modules/auth_test.go line 234 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Agree, because the code of the test is simpler than test preparation.

Done.

[dzmitryhil]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)

[ysv]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68, @silverspase, and @wojtek-coreum)

---

integration-tests/modules/authz_test.go line 264 at r2 (raw file):

		grantee,
		authztypes.NewGenericAuthorization(sdk.MsgTypeURL(&banktypes.MsgSend{})),
		time.Now().Add(time.Hour),

any specific reason to use hour in one test & minute in another ?
I suggest to stick to one version everywhere

[miladz68]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase, @wojtek-coreum, and @ysv)

---

integration-tests/modules/authz_test.go line 264 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

any specific reason to use hour in one test & minute in another ?
I suggest to stick to one version everywhere

Done.

[wojtek-coreum]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68, @silverspase, and @ysv)

---

integration-tests/modules/auth_test.go line 202 at r3 (raw file):

}

func createMultisigAccount(

Maybe it should be a method of the chain?

---

integration-tests/modules/authz_test.go line 150 at r3 (raw file):

	multisigPublicKey, keyNamesSet := createMultisigAccount(t, chain, 3, 2)
	multisigAddress, err := sdk.AccAddressFromHex(multisigPublicKey.Address().String())

what about:

multisigAddress := multisigPublicKey.Address()

?

[ysv]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @silverspase, and @wojtek-coreum)

---

integration-tests/modules/auth_test.go line 202 at r3 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

Maybe it should be a method of the chain?

good point, I agree

[miladz68]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @silverspase and @wojtek-coreum)

---

integration-tests/modules/auth_test.go line 202 at r3 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

good point, I agree

Done.

---

integration-tests/modules/authz_test.go line 150 at r3 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

what about:

multisigAddress := multisigPublicKey.Address()

?

Done.

[dzmitryhil]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)

[ysv]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @silverspase and @wojtek-coreum)

[wojtek-coreum]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase)

[wojtek-coreum]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase)

[dzmitryhil]

Reviewed 2 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase)