Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original genesis file for EncodeGenesis for testnet and mainnet. #468

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Apr 18, 2023

This change is Reviewable

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68, @silverspase, and @ysv)

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @silverspase)


pkg/config/network_test.go line 176 at r1 (raw file):

		{
			chainID:     constant.ChainIDTest,
			genesisHash: "276d5df3856ccfba9240687f463c9464e10176e0fc355efb7162e36b09b0e3af",

I didn't get why it changed ?

Copy link
Contributor Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68, @silverspase, and @ysv)


pkg/config/network_test.go line 176 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

I didn't get why it changed ?

Because for the genesis of the testnet it used the NFT (empty) which we have in the current codebase.

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @silverspase)


pkg/config/network_test.go line 176 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Because for the genesis of the testnet it used the NFT (empty) which we have in the current codebase.

ah so before we were dynamically rendering it but now we read from file
And in reality they are different

@dzmitryhil dzmitryhil merged commit 8e8b89a into master Apr 19, 2023
@dzmitryhil dzmitryhil deleted the dzmitryhil/use-genesis-bytes branch April 19, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants