-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use original genesis file for EncodeGenesis for testnet and mainnet. #468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68, @silverspase, and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @silverspase)
pkg/config/network_test.go
line 176 at r1 (raw file):
{ chainID: constant.ChainIDTest, genesisHash: "276d5df3856ccfba9240687f463c9464e10176e0fc355efb7162e36b09b0e3af",
I didn't get why it changed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68, @silverspase, and @ysv)
pkg/config/network_test.go
line 176 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
I didn't get why it changed ?
Because for the genesis of the testnet it used the NFT (empty) which we have in the current codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @silverspase)
pkg/config/network_test.go
line 176 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Because for the genesis of the testnet it used the NFT (empty) which we have in the current codebase.
ah so before we were dynamically rendering it but now we read from file
And in reality they are different
This change is