-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated readme file #470
Updated readme file #470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, @silverspase, and @ysv)
README.md
line 98 at r1 (raw file):
You can also find block explorers for each chain in this link,
Is there a comma at the end of this sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @silverspase, @wojtek-coreum, and @ysv)
README.md
line 98 at r1 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
Is there a comma at the end of this sentence?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)
README.md
line 25 at r2 (raw file):
Steps to build required binaries: 1. Clone our [crust repository](https://github.com/CoreumFoundation/crust) to the directory of your choice (let's call it `$COREUM_PATH`):
I would use the $PWD instead, and added the remark that all repos should be on the same level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @silverspase, @wojtek-coreum, and @ysv)
README.md
line 25 at r2 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
I would use the $PWD instead, and added the remark that all repos should be on the same level.
PWD
stands for Print Current Directory
, which I don't think is a good name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @silverspase, @wojtek-coreum, and @ysv)
README.md
line 25 at r2 (raw file):
Previously, miladz68 (milad) wrote…
PWD
stands forPrint Current Directory
, which I don't think is a good name.
I thought about usage of $PWD/.. / kind of, but now see the disadvantage, of using it. So let's keep the COREUM_PATH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68 and @silverspase)
README.md
line 25 at r2 (raw file):
Steps to build required binaries: 1. Clone our [crust repository](https://github.com/CoreumFoundation/crust) to the directory of your choice (let's call it `$COREUM_PATH`):
same as crust comment
lets set COREUM_PATH in the first step
Code quote:
COREUM_PATH
README.md
line 95 at r2 (raw file):
$ cored status --chain-id=coreum-devnet-1 --node=https://full-node.devnet-1.coreum.dev:26657
advice testnet here it is more stable
README.md
line 98 at r2 (raw file):
You can also find block explorers for each chain in this
by following this link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @silverspase and @ysv)
README.md
line 25 at r2 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
same as crust comment
lets set COREUM_PATH in the first step
provided an argument there.
README.md
line 95 at r2 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
advice testnet here it is more stable
Done.
README.md
line 98 at r2 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
by following this link
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase)
This change is