Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cored name in README docs #479

Merged
merged 10 commits into from
May 2, 2023
Merged

Fixed cored name in README docs #479

merged 10 commits into from
May 2, 2023

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Apr 28, 2023

This change is Reviewable

wojtek-coreum
wojtek-coreum previously approved these changes Apr 28, 2023
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @silverspase, and @ysv)

@ysv ysv requested a review from mkuvsh April 28, 2023 11:35
ysv
ysv previously approved these changes Apr 28, 2023
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @silverspase)

dzmitryhil
dzmitryhil previously approved these changes Apr 28, 2023
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkuvsh and @silverspase)

@miladz68 miladz68 dismissed stale reviews from dzmitryhil, ysv, and wojtek-coreum via 91e314e May 1, 2023 10:10
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68, @mkuvsh, and @silverspase)


README.md line 83 at r2 (raw file):

This will generate a wallet and print out the mnemonic at the end. It will also print 
the address and public key. Use the address in the next commands to query its balance
and and transfer funds to it
  1. and and
  2. period at the end

README.md line 89 at r2 (raw file):

Remember to replace address with the one existing in your keystore.

You will see the balance is zero

period at the end


README.md line 95 at r2 (raw file):

(znet) [znet] $ cored-00 tx bank send alice {YOUR_GENERATED_ADDRESS} 10udevcore --broadcast-mode=block

Run the query again and you will see that there are now funds the in the newly generated account.

the in

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkuvsh and @silverspase)

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkuvsh and @silverspase)

@miladz68 miladz68 merged commit ab52e6e into master May 2, 2023
@miladz68 miladz68 deleted the milad/fix-cored-name-docs branch May 2, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants