Add feature uniqueness check on the FT and NFT asset issuance.

[dzmitryhil]

This change is 

[wojtek-coreum]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @miladz68, @silverspase, and @ysv)

---

x/asset/ft/types/msgs.go line 58 at r1 (raw file):

	featuresSet := make(map[Feature]struct{})
	for _, feature := range msg.Features {
		if _, ok := featuresSet[feature]; ok {

ok -> exists, because it is not "ok" if value exists

---

x/asset/nft/types/msgs.go line 63 at r1 (raw file):

	featuresSet := make(map[ClassFeature]struct{})
	for _, feature := range msg.Features {
		if _, ok := featuresSet[feature]; ok {

ok -> exists

[dzmitryhil]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)

---

x/asset/ft/types/msgs.go line 58 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

ok -> exists, because it is not "ok" if value exists

Didn't get your comment.

[miladz68]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @silverspase, @wojtek-coreum, and @ysv)

---

x/asset/ft/types/msgs.go line 58 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Didn't get your comment.

I think wojtek means that exists is a better name than ok, and I agree

---

x/asset/nft/types/msgs.go line 63 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

ok -> exists

agreed

[miladz68]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @silverspase, @wojtek-coreum, and @ysv)

[dzmitryhil]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)

---

x/asset/ft/types/msgs.go line 58 at r1 (raw file):

Previously, miladz68 (milad) wrote…

I think wojtek means that exists is a better name than ok, and I agree

Ok, updated.

[ysv]

Reviewed 3 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dzmitryhil, @miladz68, @silverspase, and @wojtek-coreum)

---

x/asset/ft/types/msgs.go line 59 at r2 (raw file):

	for _, feature := range msg.Features {
		if _, exists := featuresSet[feature]; exists {
			return sdkerrors.Wrapf(ErrInvalidInput, "duplicated features in the features list")

I propose to use lo.FindDuplicates instead of duplicating this logic in FT & NFT

---

x/asset/ft/types/msgs.go line 59 at r2 (raw file):

	for _, feature := range msg.Features {
		if _, exists := featuresSet[feature]; exists {
			return sdkerrors.Wrapf(ErrInvalidInput, "duplicated features in the features list")

I think it would be beneficial to include features which are duplicated in this error ?

[miladz68]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @silverspase, and @wojtek-coreum)

[dzmitryhil]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)

---

x/asset/ft/types/msgs.go line 59 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

I propose to use lo.FindDuplicates instead of duplicating this logic in FT & NFT

Done.

Code quote:

exists := featuresSet[feature]; exis

---

x/asset/ft/types/msgs.go line 59 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

I think it would be beneficial to include features which are duplicated in this error ?

Done.

[miladz68]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)

[ysv]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)

[vertex451]

Reviewed 3 of 5 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)