Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the CI caching #482

Merged
merged 11 commits into from
May 9, 2023
Merged

Improve the CI caching #482

merged 11 commits into from
May 9, 2023

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented May 2, 2023

This change is Reviewable

@dzmitryhil dzmitryhil changed the title Print cache info in CI Draft: Improve the CI caching May 2, 2023
@dzmitryhil dzmitryhil changed the title Draft: Improve the CI caching Improve the CI caching May 3, 2023
@dzmitryhil dzmitryhil marked this pull request as ready for review May 3, 2023 08:28
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @silverspase, @wojtek-coreum, and @ysv)


.github/workflows/ci.yml line 8 at r1 (raw file):

    branches: [ master ]
  schedule:
    - cron: '0 1 * * 1' # At 01:00 on Monday

I think there is not harm in removing this cron. the first job that runs at in that week will reset the key ?

Copy link
Contributor

@vertex451 vertex451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)

Copy link
Contributor Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)


.github/workflows/ci.yml line 8 at r1 (raw file):

Previously, miladz68 (milad) wrote…

I think there is not harm in removing this cron. the first job that runs at in that week will reset the key ?

I would prefer to keep it, it helps not to wait for the caching.

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

@dzmitryhil dzmitryhil merged commit ad40e44 into master May 9, 2023
@dzmitryhil dzmitryhil deleted the dzmitryhil/ci-cache-improvements branch May 9, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants