Integrate IBC burn rate and send commission.

[dzmitryhil]

This change is 

[wojtek-coreum]

Reviewed 8 of 9 files at r1, all commit messages.
Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, @silverspase, and @ysv)

---

app/app.go line 342 at r1 (raw file):

	originalBankKeeper := bankkeeper.NewBaseKeeper(appCodec, keys[banktypes.StoreKey], app.AccountKeeper, app.GetSubspace(banktypes.ModuleName), app.ModuleAccountAddrs())
	var ibcChannelKeeper ibcchannelkeeper.Keeper
	assetFTKeeper := assetftkeeper.NewKeeper(

can't it be done after initializing ibc keeper to avoid the trick with pointer to predclared ibcChannelKeeper?

[dzmitryhil]

Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)

---

app/app.go line 342 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

can't it be done after initializing ibc keeper to avoid the trick with pointer to predclared ibcChannelKeeper?

Nope. The IBC keeper uses the staking keeper in the New function and checks whether it's nill, and the bank module is used in the staking keeper. So I've not found a better approach.

[miladz68]

Reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @silverspase, @wojtek-coreum, and @ysv)

---

.github/workflows/ci.yml line 83 at r2 (raw file):

          repository: CoreumFoundation/crust
          path: crust
          ref: dzmitryhil/add-osmosis-testing-flags # FIXME remove once merged

you can define the flags here, and use the correct default values to pass the tests.

[dzmitryhil]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)

---

.github/workflows/ci.yml line 83 at r2 (raw file):

Previously, miladz68 (milad) wrote…

you can define the flags here, and use the correct default values to pass the tests.

I wanted to be sure the with the new flags wich the crust intoduces it will pass.

[miladz68]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @silverspase, @wojtek-coreum, and @ysv)

---

.github/workflows/ci.yml line 83 at r2 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

I wanted to be sure the with the new flags wich the crust intoduces it will pass.

well now that you do, you can remove the branch name right ? there is not need to merge it into master with a FIXME

[dzmitryhil]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)

---

.github/workflows/ci.yml line 83 at r2 (raw file):

Previously, miladz68 (milad) wrote…

well now that you do, you can remove the branch name right ? there is not need to merge it into master with a FIXME

The osmosis IBC on the crust master doesn't work so that branch also contains the changes to fix it.

[miladz68]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase, @wojtek-coreum, and @ysv)

[wojtek-coreum]

Reviewed 1 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @ysv)