Added cli to fetch ft & nft params

[vertex451]

This change is 

[wojtek-coreum]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @miladz68, and @ysv)

[dzmitryhil]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @miladz68, @silverspase, and @ysv)

---

x/asset/ft/client/cli/query.go line 288 at r1 (raw file):

	cmd := &cobra.Command{
		Use:   "params",
		Short: "Query the current assetft parameters",

assetft -> use types.ModuleName instead (same for all text).

---

x/asset/ft/client/cli/query_test.go line 99 at r1 (raw file):

	requireT.NoError(ctx.Codec.UnmarshalJSON(buf.Bytes(), &resp))

	expectedIssueFee := sdk.Coin{Denom: constant.DenomDev, Amount: sdk.NewInt(10_000_000)}

Why it's constant? You should use iether the default values from types, or don't check it at all (same for the NFT test).

---

x/asset/nft/client/cli/query.go line 254 at r1 (raw file):

	cmd := &cobra.Command{
		Use:   "params",
		Short: "Query the current assetnft parameters",

assetnft -> use types.ModuleName instead (same for all text).

[miladz68]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @silverspase and @ysv)

[vertex451]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dzmitryhil and @ysv)

---

x/asset/ft/client/cli/query.go line 288 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

assetft -> use types.ModuleName instead (same for all text).

Done

---

x/asset/ft/client/cli/query_test.go line 99 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Why it's constant? You should use iether the default values from types, or don't check it at all (same for the NFT test).

I cannot find the place in the code where IssueFee is set to 10_000_000, could you please point out the place in the code?

---

x/asset/nft/client/cli/query.go line 254 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

assetnft -> use types.ModuleName instead (same for all text).

Done

[dzmitryhil]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @silverspase and @ysv)

---

x/asset/ft/client/cli/query.go line 288 at r1 (raw file):

Previously, silverspase (Artem) wrote…

Done

Don't see the changes.

[vertex451]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dzmitryhil and @ysv)

---

x/asset/ft/client/cli/query.go line 288 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Don't see the changes.

Sorry, I've published it without pushing

[dzmitryhil]

Reviewable status: 2 of 4 files reviewed, 3 unresolved discussions (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)

---

x/asset/ft/client/cli/query_test.go line 99 at r1 (raw file):

Previously, silverspase (Artem) wrote…

I cannot find the place in the code where IssueFee is set to 10_000_000, could you please point out the place in the code?

It's in the genesis. I thought we had it in the type, resolved.

[dzmitryhil]

Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @miladz68, @wojtek-coreum, and @ysv)

[miladz68]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)