Check run-unsafe flag for the unsafe functions instead of the unsafe tests. #506
Conversation
dzmitryhil
requested review from
ysv,
miladz68,
wojtek-coreum and
vertex451
as code owners
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @miladz68, @silverspase, and @ysv)
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @silverspase)
integration-tests/gov.go line 65 at r1 (raw file):
// UpdateParams goes through proposal process to update parameters. func (g Governance) UpdateParams(ctx context.Context, t *testing.T, description string, updates []paramproposal.ParamChange) error { // Fund accounts.
why not also skip it here ?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @silverspase)
integration-tests/gov.go line 65 at r1 (raw file):
Previously, miladz68 (milad) wrote…
why not also skip it here ?
It's skipped in the child function.
There was a problem hiding this comment.
Reviewable status:
# Conflicts: # integration-tests/coreum.go # integration-tests/gov.go # integration-tests/ibc/asset_ft_test.go # integration-tests/ibc/transfer_test.go # integration-tests/init.go # integration-tests/modules/assetft_test.go # integration-tests/modules/assetnft_test.go # integration-tests/modules/staking_test.go
dzmitryhil
dismissed stale reviews from miladz68, ysv, and wojtek-coreum
via
81e7342
There was a problem hiding this comment.
Reviewed 19 of 19 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 19 of 19 files at r2, all commit messages.
Reviewable status:
This change is