improved TestIBCTransferFromGaiaToCoreumAndBack test

[vertex451]

This change is 

[wojtek-coreum]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @miladz68, @silverspase, and @ysv)

---

integration-tests/ibc/transfer_test.go line 68 at r1 (raw file):

	// Fund accounts
	coreumChain.Faucet.FundAccounts(ctx, t, integrationtests.FundedAccount{

Messages: []sdk.Msg{&banksyptes.MsgSend{}}, is missing

---

integration-tests/ibc/transfer_test.go line 100 at r1 (raw file):

	)
	requireT.NoError(err)
	coreumChain.AwaitForBalance(ctx, t, coreumToGaiaSender, expectedBalanceAtCoreum)

you may check the final balance using normal bank client because the operation is done immediately

[dzmitryhil]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)

---

integration-tests/ibc/transfer_test.go line 63 at r1 (raw file):

	// Generate accounts
	gaiaAccount := gaiaChain.GenAccount()

What is the issue with prev name gaiaSender ?

---

integration-tests/ibc/transfer_test.go line 68 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

Messages: []sdk.Msg{&banksyptes.MsgSend{}}, is missing

Right and Amount: coreumChain.NewCoin(sdk.NewInt(1000000)), should be removed as well.

---

integration-tests/ibc/transfer_test.go line 80 at r1 (raw file):

	})

	// 1. Send from gaiaAccount to coreumToCoreumSender

Not sure that we need the 1. 2. indexes on the comment.

[dzmitryhil]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)

[miladz68]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)

[vertex451]

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @dzmitryhil, @miladz68, @wojtek-coreum, and @ysv)

---

integration-tests/ibc/transfer_test.go line 63 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

What is the issue with prev name gaiaSender ?

Because it is simultaneously the sender and receiver, gaiaAccount is more precise for me.

---

integration-tests/ibc/transfer_test.go line 68 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Right and Amount: coreumChain.NewCoin(sdk.NewInt(1000000)), should be removed as well.

I switched coreumChain.Faucet.FundAccounts to coreumChain.FundAccountsWithOptions.

---

integration-tests/ibc/transfer_test.go line 80 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Not sure that we need the 1. 2. indexes on the comment.

Removed

---

integration-tests/ibc/transfer_test.go line 100 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

you may check the final balance using normal bank client because the operation is done immediately

I replaced that row with the following code:

	bankClient := banktypes.NewQueryClient(coreumChain.ClientContext)
	queryBalanceResponse, err := bankClient.Balance(ctx, &banktypes.QueryBalanceRequest{
		Address: coreumToGaiaSender.String(),
		Denom:   expectedBalanceAtCoreum.Denom,
	})
	requireT.NoError(err)
	assert.Equal(t, expectedBalanceAtCoreum.Amount, queryBalanceResponse.Balance.Amount)

Is it worth replacing? For me, the previous row seemed to be fine.

And also, I don't understand why a normal bank balance check guarantees the correct balance, what if we hit the moment before the send transaction will be included in a block?

[miladz68]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)

[dzmitryhil]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @wojtek-coreum and @ysv)

[dzmitryhil]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @wojtek-coreum and @ysv)

[wojtek-coreum]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @silverspase and @ysv)

---

integration-tests/ibc/transfer_test.go line 100 at r1 (raw file):

Previously, silverspase (Artem) wrote…

I replaced that row with the following code:

	bankClient := banktypes.NewQueryClient(coreumChain.ClientContext)
	queryBalanceResponse, err := bankClient.Balance(ctx, &banktypes.QueryBalanceRequest{
		Address: coreumToGaiaSender.String(),
		Denom:   expectedBalanceAtCoreum.Denom,
	})
	requireT.NoError(err)
	assert.Equal(t, expectedBalanceAtCoreum.Amount, queryBalanceResponse.Balance.Amount)

Is it worth replacing? For me, the previous row seemed to be fine.

And also, I don't understand why a normal bank balance check guarantees the correct balance, what if we hit the moment before the send transaction will be included in a block?

But AwaitBalance have long timeout causing dealys if the test does not pass

[wojtek-coreum]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @silverspase and @ysv)

---

integration-tests/ibc/transfer_test.go line 108 at r2 (raw file):

	})
	requireT.NoError(err)
	assert.Equal(t, expectedBalanceAtCoreum.Amount, queryBalanceResponse.Balance.Amount)

Please use Amount.String() here to produce readable output

[wojtek-coreum]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @silverspase and @ysv)

[vertex451]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, @wojtek-coreum, and @ysv)

---

integration-tests/ibc/transfer_test.go line 100 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

But AwaitBalance have long timeout causing dealys if the test does not pass

Ah, I see

---

integration-tests/ibc/transfer_test.go line 108 at r2 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

Please use Amount.String() here to produce readable output

Done

[miladz68]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wojtek-coreum and @ysv)

[wojtek-coreum]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)