-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added protodoc-markdown.tmpl #528
Conversation
…n/coreum into artem/generate-proto-doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)
docs/protodoc-markdown.tmpl
line 1 at r1 (raw file):
<!-- This file is auto-generated. Please do not modify it yourself. -->
@silverspase @wojtek-coreum @miladz68 Should it be a part of the coreum or crust if the crust uses it for the generation, WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)
docs/protodoc-markdown.tmpl
line 1 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
@silverspase @wojtek-coreum @miladz68 Should it be a part of the coreum or crust if the crust uses it for the generation, WDYT ?
We can put it into the crust, but for this, we will pull the crust repo(ensure) for docs generation.
Second point - output will be placed into the Coreum repo, so it would be logical to keep input within this repo as well.
I would have the template in the Coreum repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wojtek-coreum and @ysv)
docs/protodoc-markdown.tmpl
line 1 at r1 (raw file):
Previously, silverspase (Artem) wrote…
We can put it into the crust, but for this, we will pull the crust repo(ensure) for docs generation.
Second point - output will be placed into the Coreum repo, so it would be logical to keep input within this repo as well.I would have the template in the Coreum repo.
I think it should be here, since the logic for how it should be structured is not part of crust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wojtek-coreum and @ysv)
docs/protodoc-markdown.tmpl
line 1 at r1 (raw file):
Previously, miladz68 (milad) wrote…
I think it should be here, since the logic for how it should be structured is not part of crust.
I'm ok then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)
This change is