Add more tests for FT global freeze + IBC #549
Conversation
wojtek-coreum
requested review from
dzmitryhil,
vertex451,
miladz68 and
ysv
and removed request for
a team
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)
integration-tests/ibc/asset_ft_test.go line 687 at r2 (raw file):
require.NoError(t, err) // send some coins to the other account, should work despite global freeze
Why do you need to test it here is we already test it in the different test>
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, @silverspase, and @ysv)
integration-tests/ibc/asset_ft_test.go line 687 at r2 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Why do you need to test it here is we already test it in the different test>
I don't care about it at all, but I need to send IBC transfer from non-issuer account during global freeze, so that another account needs to get tokens from the issuer
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @miladz68, @silverspase, @wojtek-coreum, and @ysv)
integration-tests/ibc/asset_ft_test.go line 687 at r2 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
I don't care about it at all, but I need to send IBC transfer from non-issuer account during global freeze, so that another account needs to get tokens from the issuer
I see.
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @miladz68, @silverspase, and @ysv)
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @silverspase and @ysv)
This change is