Improve integration tests timeouts to work with fast block time.

[dzmitryhil]

Description

The current integration tests' timeout is set with the expectation that the coreum block time and IBC chains block time are slower than 1 sec. So when we run them against the zent with faster block time, for example, 0.5sec, they pass with the time more than they can. Hence to improve it we can update the retry timeouts we use.

---

This change is 

[ysv]

considering current values for retrials should we add a validation to crust to limit block time >0.5s ?

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @miladz68, @silverspase, and @wojtek-coreum)

---

integration-tests/chain_ibc.go line 125 at r1 (raw file):

	retryCtx, retryCancel := context.WithTimeout(ctx, 30*time.Second)
	defer retryCancel()
	err := retry.Do(retryCtx, 100*time.Millisecond, func() error {

question:
Why do we have 500ms in some places & 100ms in other ?

what is the difference ?

---

integration-tests/ibc/transfer_test.go line 138 at r1 (raw file):

	osmosisChain := chains.Osmosis

	gaiaToCoreumChannelID := osmosisChain.AwaitForIBCChannelID(ctx, t, ibctransfertypes.PortID, coreumChain.ChainSettings.ChainID)

all further vars should also be renamed accordingly:
gaiaToCoreumChannelID -> osmosisToCoreumChannelID

etc

[miladz68]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @silverspase, and @wojtek-coreum)

[dzmitryhil]

Actually - not. The tests work well with any block time.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @silverspase, @wojtek-coreum, and @ysv)

---

integration-tests/chain_ibc.go line 125 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

question:
Why do we have 500ms in some places & 100ms in other ?

what is the difference ?

100ms for the operation which we expect to be executed with low delay, e.g. tx submission. And 500ms for operations we expect to be executed with high delay, e.g. channels creation.

---

integration-tests/ibc/transfer_test.go line 138 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

all further vars should also be renamed accordingly:
gaiaToCoreumChannelID -> osmosisToCoreumChannelID

etc

Make sense. Updated.

[ysv]

but for IBC tests it should be 1s+, no ?

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)

[miladz68]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)

[dzmitryhil]

Yes for IBC it will be one sec.

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)

[miladz68]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @silverspase and @wojtek-coreum)