Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enabled proto check for backwards compatiblity #580

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Re-enabled proto check for backwards compatiblity #580

merged 1 commit into from
Jul 24, 2023

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Jul 24, 2023 •
edited by CoreumDevelopment
Loading

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner July 24, 2023 08:42
@miladz68 miladz68 requested review from dzmitryhil, vertex451, ysv and wojtek-coreum and removed request for a team July 24, 2023 08:42
ysv
ysv approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @vertex451, and @wojtek-coreum)

dzmitryhil
dzmitryhil approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vertex451 and @wojtek-coreum)

@miladz68 miladz68 merged commit a92a14b into master Jul 24, 2023
@miladz68 miladz68 deleted the milad/re-enable-proto-check branch July 24, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysv ysv ysv approved these changes

@dzmitryhil dzmitryhil dzmitryhil approved these changes

@vertex451 vertex451 Awaiting requested review from vertex451 vertex451 is a code owner automatically assigned from CoreumFoundation/team-blockchain

@wojtek-coreum wojtek-coreum Awaiting requested review from wojtek-coreum wojtek-coreum is a code owner automatically assigned from CoreumFoundation/team-blockchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miladz68 @dzmitryhil @ysv