-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made before_send interceptor deterministic #590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @vertex451, and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @vertex451)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @vertex451)
453487a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @vertex451)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @vertex451)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @miladz68 and @vertex451)
integration-tests/modules/wasm_test.go
line 1657 at r2 (raw file):
msgIssue := &assetfttypes.MsgIssue{ Issuer: admin.String(), Symbol: "abc" + fmt.Sprint(i),
The tokens should start with a
and z
to let the udenom
be in the middle.
integration-tests/modules/wasm_test.go
line 1700 at r2 (raw file):
executeMsg, ) requireT.NoError(err)
You need to add one more call here, since that tx, will be accepted, but new tx after won't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), 3 unresolved discussions (waiting on @miladz68 and @vertex451)
integration-tests/modules/wasm_test.go
line 1679 at r2 (raw file):
// send coin from the contract to test wallet withdrawPayload, err := json.Marshal(map[bankMethod]bankWithdrawRequest{
Add please the comment here, that we actually test the multiple coins send here, not the wasm. And add please TODO to remove that test once we impelent: https://app.clickup.com/t/86857vqra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), 3 unresolved discussions (waiting on @dzmitryhil and @vertex451)
integration-tests/modules/wasm_test.go
line 1657 at r2 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
The tokens should start with
a
andz
to let theudenom
be in the middle.
I made it random
integration-tests/modules/wasm_test.go
line 1679 at r2 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Add please the comment here, that we actually test the multiple coins send here, not the wasm. And add please TODO to remove that test once we impelent: https://app.clickup.com/t/86857vqra
Done.
integration-tests/modules/wasm_test.go
line 1700 at r2 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
You need to add one more call here, since that tx, will be accepted, but new tx after won't.
but that was not my observation, the tx did not succeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dzmitryhil and @vertex451)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @vertex451)
This change is