Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to v3: Bump github.com/cosmos/ledger-cosmos-go to v0.12.4 to fix Ledger with CLI #729

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

ysv
Copy link
Contributor

@ysv ysv commented Nov 29, 2023

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@ysv ysv requested a review from a team as a code owner November 29, 2023 13:00
@ysv ysv requested review from dzmitryhil, miladz68 and wojtek-coreum and removed request for a team November 29, 2023 13:00
@ysv ysv changed the title Bump github.com/cosmos/ledger-cosmos-go to v0.12.4 to fix Ledger with CLI Backport to v3: Bump github.com/cosmos/ledger-cosmos-go to v0.12.4 to fix Ledger with CLI Nov 29, 2023
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@ysv ysv merged commit 287ae5a into release-v3 Nov 29, 2023
6 checks passed
@ysv ysv deleted the yaroslav/fix-ledger-in-v3 branch November 29, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants