Change WASM behaviour to default: burn vesting balance when instantiating contract

[ysv]

Description

Reviewers checklist:

• Try to write more meaningful comments with clear actions to be taken.
• Nit-picking should be unblocking. Focus on core issues.

Authors checklist

• Provide a concise and meaningful description
• Review the code yourself first, before making the PR.
• Annotate your PR in places that require explanation.
• Think and try to split the PR to smaller PR if it is big.

---

This change is 

[miladz68]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)

---

integration-tests/modules/wasm_test.go line 2229 at r2 (raw file):

		},
		{
			name: "vestingtypes.MsgCreateVestingAccount (delayed, non-vested)",

the description says non-vested, but it is vested right ?

[ysv]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)

---

integration-tests/modules/wasm_test.go line 2229 at r2 (raw file):

Previously, miladz68 (milad) wrote…

the description says non-vested, but it is vested right ?

no, this one is different
For others we wait 1 block for vesting to be completed

But this one we define EndTime: time.Now().Add(time.Minute).Unix(), so it is not vested before contract instantiation

Increase it to +1h to be sure

[miladz68]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @wojtek-coreum)

[wojtek-coreum]

Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil)

[wojtek-coreum]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil)

[dzmitryhil]

Reviewed 2 of 3 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)

[dzmitryhil]

Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)

[miladz68]

Reviewed 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)