-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change WASM behaviour to default: burn vesting balance when instantiating contract #741
Conversation
…antiating contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)
testutil/integration/faucet.go
line 133 at r2 (raw file):
func (f Faucet) collectRequests(ctx context.Context, leaderReq fundingRequest) ([]fundingRequest, error) { const ( requestsPerTx = 50
it seems that we have some issue in faucet parallelism
this tmp hotfix works & I will continue investigation later & push full fix on a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @miladz68 and @wojtek-coreum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)
testutil/integration/faucet.go
line 133 at r2 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
it seems that we have some issue in faucet parallelism
this tmp hotfix works & I will continue investigation later & push full fix on a separate PR
Ok, is it the limit of the txs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68)
testutil/integration/faucet.go
line 133 at r2 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Ok, is it the limit of the txs?
limit of requests which are packed into a single tx
I would say it is number of outputs in tx but that is not 100% true because single request might contain multiple account
…antiating contract
Description
Reviewers checklist:
Authors checklist
This change is