Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Codecov integration in CI #753

Merged
merged 8 commits into from
Dec 20, 2023
Merged

Conversation

wojtek-coreum
Copy link
Collaborator

@wojtek-coreum wojtek-coreum commented Dec 15, 2023

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@wojtek-coreum wojtek-coreum requested a review from a team as a code owner December 15, 2023 11:22
@wojtek-coreum wojtek-coreum requested review from dzmitryhil, miladz68 and ysv and removed request for a team December 15, 2023 11:22
dzmitryhil
dzmitryhil previously approved these changes Dec 18, 2023
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

Copy link

codecov bot commented Dec 18, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @wojtek-coreum)


.github/workflows/ci.yml line 150 at r3 (raw file):

        with:
          token: ${{ secrets.CODECOV_TOKEN }}
          files: ${{ github.workspace }}/coreum/coverage/coreum,${{ github.workspace }}/coreum/coverage/coreum-integration-tests

we don't create codecov for integraiton tests we do only for unit tests ?

Code quote:

coreum-integration-tests

Copy link
Collaborator Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)


.github/workflows/ci.yml line 150 at r3 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

we don't create codecov for integraiton tests we do only for unit tests ?

We didn't inspect the possibility of building a binary version which could track covered lines.
There is a potential way to do it described here: https://go.dev/doc/build-cover but it's definitely a separate task.

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @wojtek-coreum)


.github/workflows/ci.yml line 150 at r3 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

We didn't inspect the possibility of building a binary version which could track covered lines.
There is a potential way to do it described here: https://go.dev/doc/build-cover but it's definitely a separate task.

yes, I'm ok with this it is not in scope of this task
My concern is that file name is coreum-integration-tests while you do codecov for unit tests

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @wojtek-coreum)

Copy link
Collaborator Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)


.github/workflows/ci.yml line 150 at r3 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

yes, I'm ok with this it is not in scope of this task
My concern is that file name is coreum-integration-tests while you do codecov for unit tests

yes, because this is the result or running unit tests in integration-tests module

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ysv)

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

@wojtek-coreum wojtek-coreum merged commit 263ffe0 into master Dec 20, 2023
10 checks passed
@wojtek-coreum wojtek-coreum deleted the wojtek/codecov-integration branch December 20, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants