-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Codecov integration in CI #753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @wojtek-coreum)
.github/workflows/ci.yml
line 150 at r3 (raw file):
with: token: ${{ secrets.CODECOV_TOKEN }} files: ${{ github.workspace }}/coreum/coverage/coreum,${{ github.workspace }}/coreum/coverage/coreum-integration-tests
we don't create codecov for integraiton tests we do only for unit tests ?
Code quote:
coreum-integration-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)
.github/workflows/ci.yml
line 150 at r3 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
we don't create codecov for integraiton tests we do only for unit tests ?
We didn't inspect the possibility of building a binary version which could track covered lines.
There is a potential way to do it described here: https://go.dev/doc/build-cover but it's definitely a separate task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @wojtek-coreum)
.github/workflows/ci.yml
line 150 at r3 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
We didn't inspect the possibility of building a binary version which could track covered lines.
There is a potential way to do it described here: https://go.dev/doc/build-cover but it's definitely a separate task.
yes, I'm ok with this it is not in scope of this task
My concern is that file name is coreum-integration-tests
while you do codecov for unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @wojtek-coreum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)
.github/workflows/ci.yml
line 150 at r3 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
yes, I'm ok with this it is not in scope of this task
My concern is that file name iscoreum-integration-tests
while you do codecov for unit tests
yes, because this is the result or running unit tests in integration-tests
module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)
Description
Reviewers checklist:
Authors checklist
This change is