Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies due to dependabot alerts #754

Merged
merged 9 commits into from
Dec 21, 2023
Merged

Update dependencies due to dependabot alerts #754

merged 9 commits into from
Dec 21, 2023

Conversation

wojtek-coreum
Copy link
Collaborator

@wojtek-coreum wojtek-coreum commented Dec 19, 2023 •
edited by CoreumDevelopment
Loading

Description

golang.org/x/crypto v0.17.0
github.com/ethereum/go-ethereum v1.12.1

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@wojtek-coreum wojtek-coreum requested a review from a team as a code owner December 19, 2023 10:04
@wojtek-coreum wojtek-coreum requested review from dzmitryhil, miladz68 and ysv and removed request for a team December 19, 2023 10:04
dzmitryhil
dzmitryhil previously approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

miladz68
miladz68 previously approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

ysv
ysv previously approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

@wojtek-coreum wojtek-coreum dismissed stale reviews from ysv and miladz68 via d056f25 December 20, 2023 07:46
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (263ffe0) 33.14% compared to head (be557f2) 33.14%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   33.14%   33.14%           
=======================================
  Files         169      169           
  Lines       48122    48122           
=======================================
  Hits        15948    15948           
  Misses      29145    29145           
  Partials     3029     3029

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

miladz68
miladz68 previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

miladz68
miladz68 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

ysv
ysv approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

@wojtek-coreum wojtek-coreum merged commit 775e5f4 into master Dec 21, 2023
10 checks passed
@wojtek-coreum wojtek-coreum deleted the wojtek/fix-dependabot-alerts branch December 21, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysv ysv ysv approved these changes

@miladz68 miladz68 miladz68 approved these changes

@dzmitryhil dzmitryhil dzmitryhil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wojtek-coreum @dzmitryhil @miladz68 @ysv