Make integration-tests stable

[ysv]

Description

Reviewers checklist:

• Try to write more meaningful comments with clear actions to be taken.
• Nit-picking should be unblocking. Focus on core issues.

Authors checklist

• Provide a concise and meaningful description
• Review the code yourself first, before making the PR.
• Annotate your PR in places that require explanation.
• Think and try to split the PR to smaller PR if it is big.

---

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b706ad) 33.14% compared to head (2843265) 33.12%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
- Coverage   33.14%   33.12%   -0.02%     
==========================================
  Files         169      169              
  Lines       48122    48141      +19     
==========================================
  Hits        15948    15948              
- Misses      29145    29164      +19     
  Partials     3029     3029              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ysv]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)

---

pkg/client/tx.go line 297 at r2 (raw file):

	}

	if err := AwaitTargetHeight(ctx, clientCtx, txResponse.Height+3); err != nil {

waiting for 3 extra blocks helps and makes test stable in CI

if you are ok with this approach I can move this (block number to wait) into TimeoutConfig structure.
I propose to use 3 for integration-tests and for now 0 by default inside client because I'm not sure if this should be behaviour of default client.

We can live with this solution inside integration-tests for some time and see if this resolves our issue because right now I tried to run CI for ~10 times and had no failures

[miladz68]

Reviewed 1 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)

---

pkg/client/tx.go line 297 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

waiting for 3 extra blocks helps and makes test stable in CI

if you are ok with this approach I can move this (block number to wait) into TimeoutConfig structure.
I propose to use 3 for integration-tests and for now 0 by default inside client because I'm not sure if this should be behaviour of default client.

We can live with this solution inside integration-tests for some time and see if this resolves our issue because right now I tried to run CI for ~10 times and had no failures

I think it is ok for now.

[miladz68]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)

[ysv]

Reviewable status: 3 of 7 files reviewed, all discussions resolved (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)

---

pkg/client/tx.go line 297 at r2 (raw file):

Previously, miladz68 (milad) wrote…

I think it is ok for now.

ok, moved it to a separate config & fixed some one issue in tests

[miladz68]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @wojtek-coreum)