Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide authz into 3 contracts #762

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Divide authz into 3 contracts #762

merged 3 commits into from
Jan 9, 2024

Conversation

keyleu
Copy link
Collaborator

@keyleu keyleu commented Jan 4, 2024

Description

Divide the current authz contract into 3 different contracts: one for testing transfer, one for NFT trades and one for stargate operations.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@keyleu keyleu requested a review from a team as a code owner January 4, 2024 16:57
@keyleu keyleu requested review from dzmitryhil, miladz68, ysv and wojtek-coreum and removed request for a team January 4, 2024 16:57
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a9050a) 33.12% compared to head (c06f824) 33.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #762   +/-   ##
=======================================
  Coverage   33.12%   33.12%           
=======================================
  Files         169      169           
  Lines       48141    48141           
=======================================
  Hits        15948    15948           
  Misses      29164    29164           
  Partials     3029     3029           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 24 files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, @wojtek-coreum, and @ysv)


integration-tests/modules/wasm_test.go line 859 at r1 (raw file):

	)
	require.NoError(t, err)
	requireT.Equal(chain.GasLimitByMsgs(grantMsg), uint64(txResult.GasUsed))

Why do you need to check that here? IMO if we have tested the deperministic gas in different test, then no need to repeat that check.

Copy link
Collaborator Author

@keyleu keyleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 24 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, @wojtek-coreum, and @ysv)


integration-tests/modules/wasm_test.go line 859 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Why do you need to check that here? IMO if we have tested the deperministic gas in different test, then no need to repeat that check.

Right, removed it.

@ysv ysv requested a review from dzmitryhil January 8, 2024 11:32
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 23 of 24 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 24 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @wojtek-coreum)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)

@keyleu keyleu merged commit da9df45 into master Jan 9, 2024
10 checks passed
@keyleu keyleu deleted the keyne/divide-authz-contract branch January 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants