-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divide authz into 3 contracts #762
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #762 +/- ##
=======================================
Coverage 33.12% 33.12%
=======================================
Files 169 169
Lines 48141 48141
=======================================
Hits 15948 15948
Misses 29164 29164
Partials 3029 3029 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 24 files reviewed, 1 unresolved discussion (waiting on @keyleu, @miladz68, @wojtek-coreum, and @ysv)
integration-tests/modules/wasm_test.go
line 859 at r1 (raw file):
) require.NoError(t, err) requireT.Equal(chain.GasLimitByMsgs(grantMsg), uint64(txResult.GasUsed))
Why do you need to check that here? IMO if we have tested the deperministic gas in different test, then no need to repeat that check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 24 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, @wojtek-coreum, and @ysv)
integration-tests/modules/wasm_test.go
line 859 at r1 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Why do you need to check that here? IMO if we have tested the deperministic gas in different test, then no need to repeat that check.
Right, removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 23 of 24 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 24 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @wojtek-coreum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)
Description
Divide the current authz contract into 3 different contracts: one for testing transfer, one for NFT trades and one for stargate operations.
Reviewers checklist:
Authors checklist
This change is