Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v4 TODOs #771

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Fix v4 TODOs #771

merged 3 commits into from
Jan 16, 2024

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Jan 12, 2024

Description

  • Remove legacy TestWASMBankSendContractWithMultipleFundsAttached test.
  • Move some TODOs to v5
  • Add comments for the block legacy RPC results

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@dzmitryhil dzmitryhil requested a review from a team as a code owner January 12, 2024 08:52
@dzmitryhil dzmitryhil requested review from miladz68, ysv and wojtek-coreum and removed request for a team January 12, 2024 08:52
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a7e569) 33.12% compared to head (295215f) 33.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   33.12%   33.12%           
=======================================
  Files         169      169           
  Lines       48141    48141           
=======================================
  Hits        15948    15948           
  Misses      29164    29164           
  Partials     3029     3029           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Add comments for the block legacy RPC results
@dzmitryhil dzmitryhil changed the title Remove legacy TestWASMBankSendContractWithMultipleFundsAttached test. Fix v4 todos Jan 15, 2024
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@dzmitryhil dzmitryhil merged commit cac7563 into master Jan 16, 2024
10 checks passed
@dzmitryhil dzmitryhil deleted the dzmitryhil/remvoe-legacy-test branch January 16, 2024 09:30
@dzmitryhil dzmitryhil changed the title Fix v4 todos Fix v4 TODOs Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants