Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate codecov into integration-tests/modules #777

Merged
merged 4 commits into from
Feb 4, 2024

Conversation

ysv
Copy link
Contributor

@ysv ysv commented Jan 26, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@ysv ysv requested a review from a team as a code owner January 26, 2024 18:37
@ysv ysv requested review from dzmitryhil, miladz68 and wojtek-coreum and removed request for a team January 26, 2024 18:37
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2f48c6) 33.05% compared to head (0a112be) 36.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
+ Coverage   33.05%   36.26%   +3.21%     
==========================================
  Files         171      172       +1     
  Lines       48280    48299      +19     
==========================================
+ Hits        15957    17515    +1558     
+ Misses      29294    27526    -1768     
- Partials     3029     3258     +229     
Flag Coverage Δ
coreum 33.05% <ø> (?)
coreum-integration-tests-modules 18.07% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ysv ysv changed the title [WIP] Integrate codecov into integration-tests/modules Integrate codecov into integration-tests/modules Jan 26, 2024
wojtek-coreum
wojtek-coreum previously approved these changes Jan 30, 2024
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @miladz68)

dzmitryhil
dzmitryhil previously approved these changes Jan 30, 2024
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

@ysv ysv dismissed stale reviews from dzmitryhil and wojtek-coreum via daa828e February 1, 2024 12:18
@ysv ysv force-pushed the yaroslav/integr-tests-codecov-v2 branch from 243a671 to 8a12f90 Compare February 2, 2024 11:24
Copy link
Contributor Author

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)


build/go.mod line 3 at r2 (raw file):

module github.com/CoreumFoundation/coreum/build

// 1.20 is used here because still not all distros deliver 1.21.

@wojtek-coreum this comment is not relevant here so I removed it


build/go.mod line 21 at r3 (raw file):

	github.com/spf13/pflag v1.0.5 // indirect
	go.uber.org/multierr v1.11.0 // indirect
	// Make sure to not bump x/exp dependency without cosmos-sdk updated because their breaking change is not compatible

@miladz68 @wojtek-coreum @dzmitryhil pls note this
otherwise weird build failure happens because when you update almost any dep x/exp also gets updated

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)


build/go.mod line 3 at r2 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

@wojtek-coreum this comment is not relevant here so I removed it

or you might update it to 1.21 is used ...

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68)

@ysv ysv merged commit 5cbf342 into master Feb 4, 2024
10 checks passed
@ysv ysv deleted the yaroslav/integr-tests-codecov-v2 branch February 4, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants