-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate codecov into integration-tests/modules #777
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #777 +/- ##
==========================================
+ Coverage 33.05% 36.26% +3.21%
==========================================
Files 171 172 +1
Lines 48280 48299 +19
==========================================
+ Hits 15957 17515 +1558
+ Misses 29294 27526 -1768
- Partials 3029 3258 +229
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @miladz68)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68)
243a671
to
8a12f90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)
build/go.mod
line 3 at r2 (raw file):
module github.com/CoreumFoundation/coreum/build // 1.20 is used here because still not all distros deliver 1.21.
@wojtek-coreum this comment is not relevant here so I removed it
build/go.mod
line 21 at r3 (raw file):
github.com/spf13/pflag v1.0.5 // indirect go.uber.org/multierr v1.11.0 // indirect // Make sure to not bump x/exp dependency without cosmos-sdk updated because their breaking change is not compatible
@miladz68 @wojtek-coreum @dzmitryhil pls note this
otherwise weird build failure happens because when you update almost any dep x/exp
also gets updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68)
build/go.mod
line 3 at r2 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
@wojtek-coreum this comment is not relevant here so I removed it
or you might update it to 1.21 is used ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68)
Description
Reviewers checklist:
Authors checklist
This change is