-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to generate unsigned Tx #778
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #778 +/- ##
==========================================
- Coverage 33.06% 33.05% -0.01%
==========================================
Files 171 171
Lines 48266 48280 +14
==========================================
Hits 15957 15957
- Misses 29280 29294 +14
Partials 3029 3029 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)
pkg/client/tx.go
line 87 at r2 (raw file):
key, err := clientCtx.Keyring().KeyByAddress(clientCtx.FromAddress()) if err != nil { return nil, errors.Errorf("failed to get key by the address %q from the keyring", clientCtx.FromAddress().String())
Wrapf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)
pkg/client/tx.go
line 87 at r2 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Wrapf
I am not getting this, maybe you are pointing to the wrong line ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)
pkg/client/tx.go
line 87 at r2 (raw file):
Previously, miladz68 (milad) wrote…
I am not getting this, maybe you are pointing to the wrong line ?
Check by text: failed to get key by the addres
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)
pkg/client/tx.go
line 87 at r2 (raw file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Check by text:
failed to get key by the addres
I see now, that line is not part of the code changes. Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ysv)
Description
Add function to generate unsigned Tx
Reviewers checklist:
Authors checklist
This change is