Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to generate unsigned Tx #778

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Jan 31, 2024

Description

Add function to generate unsigned Tx

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner January 31, 2024 10:54
@miladz68 miladz68 requested review from dzmitryhil, ysv and wojtek-coreum and removed request for a team January 31, 2024 10:54
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd1e810) 33.06% compared to head (47d889a) 33.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
- Coverage   33.06%   33.05%   -0.01%     
==========================================
  Files         171      171              
  Lines       48266    48280      +14     
==========================================
  Hits        15957    15957              
- Misses      29280    29294      +14     
  Partials     3029     3029              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)


pkg/client/tx.go line 87 at r2 (raw file):

		key, err := clientCtx.Keyring().KeyByAddress(clientCtx.FromAddress())
		if err != nil {
			return nil, errors.Errorf("failed to get key by the address %q from the keyring", clientCtx.FromAddress().String())

Wrapf

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)


pkg/client/tx.go line 87 at r2 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Wrapf

I am not getting this, maybe you are pointing to the wrong line ?

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)


pkg/client/tx.go line 87 at r2 (raw file):

Previously, miladz68 (milad) wrote…

I am not getting this, maybe you are pointing to the wrong line ?

Check by text: failed to get key by the addres

wojtek-coreum
wojtek-coreum previously approved these changes Jan 31, 2024
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68 and @ysv)

Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)


pkg/client/tx.go line 87 at r2 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Check by text: failed to get key by the addres

I see now, that line is not part of the code changes. Done.

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@miladz68 miladz68 merged commit a2f48c6 into master Feb 1, 2024
10 checks passed
@miladz68 miladz68 deleted the milad/generate-only-tx branch February 1, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants