Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions in CI to v4 #789

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Mar 1, 2024

Description

Update github actions in CI to v4.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner March 1, 2024 07:14
@miladz68 miladz68 requested review from dzmitryhil, ysv and wojtek-coreum and removed request for a team March 1, 2024 07:14
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.45%. Comparing base (abbdace) to head (4b267fa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
+ Coverage   35.26%   36.45%   +1.18%     
==========================================
  Files         171      171              
  Lines       47469    47469              
==========================================
+ Hits        16742    17305     +563     
+ Misses      27482    26892     -590     
- Partials     3245     3272      +27     
Flag Coverage Δ
coreum 32.01% <ø> (ø)
coreum-integration-tests-modules 22.48% <ø> (+5.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)

a discussion (no related file):
Won't it conflict with the other CI PR ? IMO you can update the version there.


Copy link
Contributor Author

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)

a discussion (no related file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Won't it conflict with the other CI PR ? IMO you can update the version there.

It won't conflict. I intentionally broken this down, since these 2 are not related.


@ysv ysv requested a review from dzmitryhil March 1, 2024 10:41
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @wojtek-coreum)

a discussion (no related file):

Previously, miladz68 (milad) wrote…

It won't conflict. I intentionally broken this down, since these 2 are not related.

I'm ok Milad's approach (to brake it)


Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

@miladz68 miladz68 merged commit ab054cc into master Mar 1, 2024
10 checks passed
@miladz68 miladz68 deleted the milad/update-ci-actions-v4 branch March 1, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants