-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github actions in CI to v4 #789
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #789 +/- ##
==========================================
+ Coverage 35.26% 36.45% +1.18%
==========================================
Files 171 171
Lines 47469 47469
==========================================
+ Hits 16742 17305 +563
+ Misses 27482 26892 -590
- Partials 3245 3272 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)
a discussion (no related file):
Won't it conflict with the other CI PR ? IMO you can update the version there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)
a discussion (no related file):
Previously, dzmitryhil (Dzmitry Hil) wrote…
Won't it conflict with the other CI PR ? IMO you can update the version there.
It won't conflict. I intentionally broken this down, since these 2 are not related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @wojtek-coreum)
a discussion (no related file):
Previously, miladz68 (milad) wrote…
It won't conflict. I intentionally broken this down, since these 2 are not related.
I'm ok Milad's approach (to brake it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)
Description
Update github actions in CI to v4.
Reviewers checklist:
Authors checklist
This change is