Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub action versions to latest. #791

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Mar 12, 2024

Description

Update GitHub action versions to latest.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@dzmitryhil dzmitryhil requested a review from a team as a code owner March 12, 2024 12:01
@dzmitryhil dzmitryhil requested review from miladz68, ysv and wojtek-coreum and removed request for a team March 12, 2024 12:01
miladz68
miladz68 previously approved these changes Mar 12, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

wojtek-coreum
wojtek-coreum previously approved these changes Mar 13, 2024
Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@dzmitryhil dzmitryhil dismissed stale reviews from wojtek-coreum and miladz68 via af0bcb6 March 14, 2024 06:10
@dzmitryhil dzmitryhil force-pushed the dzmitryhil/update-github-action-versions branch from 71d3579 to af0bcb6 Compare March 14, 2024 06:10
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.47%. Comparing base (7981307) to head (11e734b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
- Coverage   36.51%   36.47%   -0.05%     
==========================================
  Files         171      171              
  Lines       47481    47481              
==========================================
- Hits        17336    17317      -19     
- Misses      26878    26892      +14     
- Partials     3267     3272       +5     
Flag Coverage Δ
coreum 32.03% <ø> (ø)
coreum-integration-tests-modules 22.50% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil and @ysv)


.github/workflows/ci.yml line 116 at r1 (raw file):

      - name: Setup WASM cache
        uses: actions/cache@v4
        if: ${{ matrix.wasm-cache }}

Why do you remove all those ifs?

Copy link
Contributor Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wojtek-coreum and @ysv)


.github/workflows/ci.yml line 116 at r1 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

Why do you remove all those ifs?

Because of 2 reasons.

  1. Some ifs are always - true
  2. We use a common cache for all subcommands, so no need to make it optional

Copy link
Collaborator

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@dzmitryhil dzmitryhil merged commit 55b1e5f into master Mar 15, 2024
10 checks passed
@dzmitryhil dzmitryhil deleted the dzmitryhil/update-github-action-versions branch March 15, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants