-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CI to use coreum-builder
#798
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
==========================================
+ Coverage 34.69% 35.89% +1.20%
==========================================
Files 171 171
Lines 48334 48334
==========================================
+ Hits 16769 17351 +582
+ Misses 28316 27712 -604
- Partials 3249 3271 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @masihyeganeh, and @miladz68)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @masihyeganeh, and @miladz68)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 7 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @miladz68)
# Conflicts: # .github/workflows/ci.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 7 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @wojtek-coreum)
.github/workflows/ci.yml
line 36 at r4 (raw file):
- ci_step: "integration tests coreum-modules" command: | coreum-builder build/integration-tests/modules build images
It was decided to merge all build related steps into a separate step. You should merge all these build commands there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 8 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @ysv)
.github/workflows/ci.yml
line 36 at r4 (raw file):
Previously, miladz68 (milad) wrote…
It was decided to merge all build related steps into a separate step. You should merge all these build commands there
Now, dependencies are downloaded before building, so cache will be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @wojtek-coreum)
.github/workflows/ci.yml
line 36 at r4 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
Now, dependencies are downloaded before building, so cache will be fine
was this discussed in the team ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @miladz68)
.github/workflows/ci.yml
line 36 at r4 (raw file):
Previously, miladz68 (milad) wrote…
was this discussed in the team ?
yes, while you was on vacation. We may do it again if you want to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
.github/workflows/ci.yml
line 36 at r4 (raw file):
Previously, wojtek-coreum (Wojtek) wrote…
yes, while you was on vacation. We may do it again if you want to
No need. Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r1, 7 of 7 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 9 files reviewed, all discussions resolved (waiting on @dzmitryhil, @keyleu, and @masihyeganeh)
integration-tests/modules/staking_test.go
line 292 at r9 (raw file):
// delegation is higher than current validator self delegation. func TestValidatorUpdateWithLowMinSelfDelegation(t *testing.T) { // Since this test changes global staking config we can't run it in parallel with other tests.
evidence of failure: https://github.com/CoreumFoundation/coreum/actions/runs/8680049544/job/23819785222?pr=798#step:15:1510
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 9 files reviewed, all discussions resolved (waiting on @keyleu and @masihyeganeh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 7 files at r8, 1 of 2 files at r9, 5 of 5 files at r12.
Reviewable status: 11 of 12 files reviewed, all discussions resolved (waiting on @keyleu and @masihyeganeh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 10 of 12 files reviewed, all discussions resolved (waiting on @keyleu, @masihyeganeh, and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 7 files at r8, 1 of 2 files at r9, 3 of 5 files at r12, 1 of 1 files at r13, 1 of 1 files at r14, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @keyleu and @masihyeganeh)
Description
--help
command for builderReviewers checklist:
Authors checklist
This change is