Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vulnerable dependencies #807

Merged
merged 13 commits into from
Apr 29, 2024
Merged

Conversation

masihyeganeh
Copy link
Contributor

@masihyeganeh masihyeganeh commented Apr 18, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.81%. Comparing base (b8a5277) to head (64b2f65).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   35.58%   36.81%   +1.22%     
==========================================
  Files         165      165              
  Lines       48956    48956              
==========================================
+ Hits        17420    18021     +601     
+ Misses      28149    27531     -618     
- Partials     3387     3404      +17     
Flag Coverage Δ
coreum 32.46% <ø> (ø)
coreum-integration-tests-modules 22.83% <ø> (+5.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masihyeganeh masihyeganeh marked this pull request as ready for review April 19, 2024 13:55
@masihyeganeh masihyeganeh requested a review from a team as a code owner April 19, 2024 13:55
@masihyeganeh masihyeganeh requested review from dzmitryhil, miladz68, ysv and wojtek-coreum and removed request for a team April 19, 2024 13:55
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 28 files reviewed, 2 unresolved discussions (waiting on @masihyeganeh, @miladz68, @wojtek-coreum, and @ysv)


go.mod line 14 at r1 (raw file):

	// TODO(v4) Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409
	github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.0
	// Remove this line after updating crust
  1. Make the commet FIXME: ... please, for such case.
  2. Is the crust version you need already in PR ?

build/go.mod line 7 at r1 (raw file):

replace (
	github.com/CoreumFoundation/coreum/v4 => ../
	golang.org/x/exp => golang.org/x/exp v0.0.0-20230711153332-06a737ee72cb

Is it the same replace as in coreum go.mod? If yes, leave same comment here as well please.

Copy link
Contributor Author

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 28 files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @miladz68, @wojtek-coreum, and @ysv)


go.mod line 14 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…
  1. Make the commet FIXME: ... please, for such case.
  2. Is the crust version you need already in PR ?
  1. Fixed
  2. Yes

build/go.mod line 7 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Is it the same replace as in coreum go.mod? If yes, leave same comment here as well please.

Done.

miladz68
miladz68 previously approved these changes Apr 23, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @wojtek-coreum, and @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @wojtek-coreum, and @ysv)


go.mod line 14 at r1 (raw file):

Previously, masihyeganeh (Masih Yeganeh) wrote…
  1. Fixed
  2. Yes

So you can import it aready by hash. And leave TODO to update later, isn't it?

Copy link
Contributor Author

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 21 of 28 files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, @wojtek-coreum, and @ysv)


go.mod line 14 at r1 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

So you can import it aready by hash. And leave TODO to update later, isn't it?

Done.

miladz68
miladz68 previously approved these changes Apr 26, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

miladz68
miladz68 previously approved these changes Apr 26, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

dzmitryhil
dzmitryhil previously approved these changes Apr 26, 2024
Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 21 of 28 files at r1, 4 of 7 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum and @ysv)

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 21 of 28 files at r1, 4 of 7 files at r4, 3 of 3 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @wojtek-coreum)

a discussion (no related file):
Lets add @keyleu to review rust changes


@ysv ysv requested a review from keyleu April 26, 2024 16:20
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @keyleu, @masihyeganeh, and @wojtek-coreum)

Copy link
Collaborator

@keyleu keyleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @masihyeganeh and @wojtek-coreum)


integration-tests/contracts/modules/bank-send/Cargo.toml line 31 at r7 (raw file):

[dependencies]
cosmwasm-std = "1.2.3"

1.5.3 here

miladz68
miladz68 previously approved these changes Apr 29, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @masihyeganeh and @wojtek-coreum)

Copy link
Contributor Author

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 27 of 29 files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @keyleu, @miladz68, @wojtek-coreum, and @ysv)

a discussion (no related file):

Previously, ysv (Yaroslav Savchuk) wrote…

Lets add @keyleu to review rust changes

Done.



integration-tests/contracts/modules/bank-send/Cargo.toml line 31 at r7 (raw file):

Previously, keyleu (Keyne) wrote…

1.5.3 here

Done.

@ysv ysv requested a review from keyleu April 29, 2024 13:07
Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @keyleu and @wojtek-coreum)

Copy link
Collaborator

@keyleu keyleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 28 files at r1, 4 of 7 files at r4, 3 of 3 files at r6, 2 of 2 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wojtek-coreum)

Copy link
Collaborator

@keyleu keyleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r6, 2 of 2 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wojtek-coreum)

@masihyeganeh masihyeganeh merged commit 7dea742 into master Apr 29, 2024
10 checks passed
@masihyeganeh masihyeganeh deleted the masih/fix-vulnerabilities branch April 29, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants