Check the NFT data for nil when updating the dynamic data.

[dzmitryhil]

Description

Check the NFT data for nil when updating the dynamic data.

Reviewers checklist:

• Try to write more meaningful comments with clear actions to be taken.
• Nit-picking should be unblocking. Focus on core issues.

Authors checklist

• Provide a concise and meaningful description
• Review the code yourself first, before making the PR.
• Annotate your PR in places that require explanation.
• Think and try to split the PR to smaller PR if it is big.

---

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.82%. Comparing base (7dea742) to head (229b05d).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
+ Coverage   35.58%   36.82%   +1.23%     
==========================================
  Files         165      165              
  Lines       48956    48959       +3     
==========================================
+ Hits        17420    18027     +607     
+ Misses      28149    27529     -620     
- Partials     3387     3403      +16     

Flag	Coverage Δ
coreum	32.47% <ø> (+0.01%)	⬆️
coreum-integration-tests-modules	22.80% <ø> (+5.73%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ysv]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @wojtek-coreum)

---

x/asset/nft/keeper/keeper.go line 382 at r1 (raw file):

		return sdkerrors.Wrapf(types.ErrNFTNotFound, "nft with classID:%s and ID:%s not found", classID, id)
	}
	if storedNFT.Data == nil {

btw do we have check that our Data changes are compatible with v3 ?

Maybe we need to add test into upgrade integration tests ?

[dzmitryhil]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, @wojtek-coreum, and @ysv)

---

x/asset/nft/keeper/keeper.go line 382 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

btw do we have check that our Data changes are compatible with v3 ?

Maybe we need to add test into upgrade integration tests ?

We didn't change the data, so it's compatible.

[miladz68]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @wojtek-coreum, and @ysv)

[ysv]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @wojtek-coreum)