-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve integration tests gas price and gas adjustments. #836
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #836 +/- ##
===========================================
+ Coverage 23.76% 37.06% +13.29%
===========================================
Files 176 182 +6
Lines 52278 52713 +435
===========================================
+ Hits 12425 19536 +7111
+ Misses 37433 29639 -7794
- Partials 2420 3538 +1118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @wojtek-coreum)
testutil/integration/gov.go
line 226 at r1 (raw file):
msg := msgFunc(staker) txf := g.chainCtx.TxFactory().WithSimulateAndExecute(true).WithGasAdjustment(voteGasAdjustment)
nit: could you remind why we need this adjustment only inside gov ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @miladz68, and @wojtek-coreum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @miladz68, @wojtek-coreum, and @ysv)
testutil/integration/gov.go
line 226 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
nit: could you remind why we need this adjustment only inside gov ?
Because the Coreum gas adjustment is 1
, so when we use WithSimulateAndExecute(true)
there is a high chance that at the time of the execution gas will be different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)
Description
Reviewers checklist:
Authors checklist
This change is