-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usd DNS for default coreum seeds. #837
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
=======================================
Coverage 35.95% 35.95%
=======================================
Files 182 182
Lines 52709 52709
=======================================
Hits 18954 18954
Misses 30229 30229
Partials 3526 3526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @wojtek-coreum)
pkg/config/network.go
line 48 at r1 (raw file):
SeedPeers: []string{ "64391878009b8804d90fda13805e45041f492155@seed-sirius.testnet-1.coreum.dev:26656", // seed-sirius "53f2367d8f8291af8e3b6ca60efded0675ff6314@seed-antares.mainnet-1.coreum.dev:26656", // seed-antares
should it be testnet-1 here ?
Code quote:
seed-antares.mainnet-1.coreum.dev:26656"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, @wojtek-coreum, and @ysv)
pkg/config/network.go
line 48 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
should it be testnet-1 here ?
Correct, fixed in registry, but missed here. Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @wojtek-coreum, and @ysv)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @wojtek-coreum)
Description
Reviewers checklist:
Authors checklist
This change is