Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coreum V4 upgrade alias for the v4 upgrade. #905

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented Jul 9, 2024

Description

Add Coreum V4 upgrade alias for the v4 upgrade.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@dzmitryhil dzmitryhil requested a review from a team as a code owner July 9, 2024 07:15
@dzmitryhil dzmitryhil requested review from masihyeganeh, miladz68 and ysv and removed request for a team July 9, 2024 07:15
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @ysv)

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.11%. Comparing base (75581f0) to head (95e38a3).
Report is 3 commits behind head on release-v4.

Additional details and impacted files
@@             Coverage Diff             @@
##           release-v4     #905   +/-   ##
===========================================
  Coverage       38.11%   38.11%           
===========================================
  Files             168      168           
  Lines           51789    51790    +1     
===========================================
+ Hits            19740    19741    +1     
  Misses          28482    28482           
  Partials         3567     3567           
Flag Coverage Δ
coreum 34.09% <100.00%> (+<0.01%) ⬆️
coreum-integration-tests-modules 24.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@dzmitryhil dzmitryhil merged commit 5e3c62b into release-v4 Jul 9, 2024
9 checks passed
@dzmitryhil dzmitryhil deleted the dzmitryhil/add-coreum-v4-upgrade-name branch July 9, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants