Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade wasmd deps #933

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

miladz68
Copy link
Contributor

@miladz68 miladz68 commented Aug 26, 2024

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner August 26, 2024 13:55
@miladz68 miladz68 requested review from masihyeganeh, dzmitryhil and ysv and removed request for a team August 26, 2024 13:55
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.64%. Comparing base (5e3c62b) to head (31dd3e6).
Report is 2 commits behind head on release-v4.

Files with missing lines Patch % Lines
app/upgrade/v4patch1/upgrade.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-v4     #933       +/-   ##
===============================================
+ Coverage       38.11%   66.64%   +28.52%     
===============================================
  Files             168      134       -34     
  Lines           51790    13076    -38714     
===============================================
- Hits            19741     8714    -11027     
+ Misses          28482     3628    -24854     
+ Partials         3567      734     -2833     
Flag Coverage Δ
coreum 58.32% <70.00%> (+24.22%) ⬆️
coreum-integration-tests-modules 50.42% <70.00%> (+26.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

masihyeganeh
masihyeganeh previously approved these changes Aug 27, 2024
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil and @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@miladz68 miladz68 merged commit 4250e1b into release-v4 Aug 27, 2024
8 of 9 checks passed
@miladz68 miladz68 deleted the milad/upgrade-wasmd-deps-release-v4 branch August 27, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants