Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI cache to ScribeMD/docker-cache. #209

Merged
merged 5 commits into from
May 16, 2024

Conversation

dzmitryhil
Copy link
Contributor

@dzmitryhil dzmitryhil commented May 13, 2024

Description

Update CI cache to ScribeMD/docker-cache.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@dzmitryhil dzmitryhil requested a review from a team as a code owner May 13, 2024 08:20
@dzmitryhil dzmitryhil requested review from masihyeganeh, miladz68, ysv and wojtek-coreum and removed request for a team May 13, 2024 08:20
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dzmitryhil, @masihyeganeh, @miladz68, and @wojtek-coreum)


integration-tests/xrpl.go line 195 at r1 (raw file):

	require.NoError(t, c.signer.Sign(&fundXrpTx, faucetKeyringKeyName))

	//t.Logf("Funding account, account address: %s, amount: %f", acc, amount)

shall we remove comments or log lines ?


integration-tests/xrpl/matching_test.go line 1 at r1 (raw file):

//go:build integrationtests

pls remove this

@dzmitryhil dzmitryhil requested a review from ysv May 15, 2024 05:30
Copy link
Contributor Author

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 4 files reviewed, 2 unresolved discussions (waiting on @masihyeganeh, @miladz68, @wojtek-coreum, and @ysv)


integration-tests/xrpl.go line 195 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

shall we remove comments or log lines ?

Done.


integration-tests/xrpl/matching_test.go line 1 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

pls remove this

Done.

miladz68
miladz68 previously approved these changes May 15, 2024
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @masihyeganeh, @wojtek-coreum, and @ysv)

ysv
ysv previously approved these changes May 15, 2024
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @wojtek-coreum)

# Conflicts:
#	.github/workflows/relayer-ci.yml
@dzmitryhil dzmitryhil dismissed stale reviews from ysv and miladz68 via 08a9daa May 15, 2024 09:27
@dzmitryhil dzmitryhil requested review from miladz68 and ysv May 15, 2024 09:27
ysv
ysv previously approved these changes May 15, 2024
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh, @miladz68, and @wojtek-coreum)

@dzmitryhil dzmitryhil requested a review from ysv May 15, 2024 11:14
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh, @miladz68, and @wojtek-coreum)

Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2, 1 of 2 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @wojtek-coreum)

@dzmitryhil dzmitryhil merged commit a5a7a0d into master May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants